Skip to content

Conversation

@sarbazx
Copy link

@sarbazx sarbazx commented Aug 17, 2025

CleanShot 2025-08-17 at 22 14 06@2x

@vercel
Copy link

vercel bot commented Aug 17, 2025

@sarbazx is attempting to deploy a commit to the Conrad's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
keyboard-signature Ready Ready Preview Comment Aug 17, 2025 7:37pm

@cnrad
Copy link
Owner

cnrad commented Aug 17, 2025

Could you pull the latest changes from main and resolve the merge conflicts?

One other thing I'm wary of is changing the SVG height (from 200px to 250px) - just make sure this doesn't make exported SVG/PNG sizes look weird for other layouts. You could probably change the height conditionally to avoid this.

@sarbazx
Copy link
Author

sarbazx commented Aug 18, 2025

Could you pull the latest changes from main and resolve the merge conflicts?

One other thing I'm wary of is changing the SVG height (from 200px to 250px) - just make sure this doesn't make exported SVG/PNG sizes look weird for other layouts. You could probably change the height conditionally to avoid this.

Hello,

resolved the merge conflicts and added additional check for SVG height.

@sarbazx
Copy link
Author

sarbazx commented Sep 28, 2025

Hello @cnrad,

is there any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants