Skip to content

Fix OperationResponseAssociation not using configured connection#577

Merged
cnizzardini merged 5 commits intocnizzardini:masterfrom
jamisonbryant:feature/fix-opresponseassn-using-default-conn
Oct 19, 2025
Merged

Fix OperationResponseAssociation not using configured connection#577
cnizzardini merged 5 commits intocnizzardini:masterfrom
jamisonbryant:feature/fix-opresponseassn-using-default-conn

Conversation

@jamisonbryant
Copy link
Copy Markdown
Contributor

Fixes #576

@cnizzardini
Copy link
Copy Markdown
Owner

cnizzardini commented Oct 17, 2025

Thanks. I will pull this down in the next couple of days and test it. Looks good though and should be able to put this in a release soon!

@cnizzardini cnizzardini requested a review from Copilot October 17, 2025 15:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where OperationResponseAssociation was not using the configured database connection and instead defaulting to 'default'. The fix ensures that the class respects the connection name specified in the configuration.

  • Updated OperationResponseAssociation constructor to accept a Configuration parameter
  • Modified the database connection retrieval to use the configured connection name instead of hardcoded 'default'
  • Updated all test cases and calling code to pass the configuration parameter

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Lib/Operation/OperationResponseAssociation.php Added Configuration parameter to constructor and updated connection retrieval logic
src/Lib/Operation/OperationResponse.php Updated instantiation to pass Configuration parameter
tests/TestCase/Lib/Operation/OperationResponseAssociationTest.php Added test connection configuration and updated all test instantiations
tests/TestCase/Lib/MediaType/JsonLdTest.php Added test connection configuration and updated instantiations
tests/TestCase/Lib/MediaType/HalJsonTest.php Added test connection configuration and updated instantiations
tests/test_app/src/Controller/OperationPathController.php Updated parameter signature to use nullable type syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cnizzardini cnizzardini merged commit 2c6a9ce into cnizzardini:master Oct 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OperationResponseAssociation::getOrCreateAssociatedSchema uses 'default' connection instead of configured

3 participants