Fix OperationResponseAssociation not using configured connection#577
Merged
cnizzardini merged 5 commits intocnizzardini:masterfrom Oct 19, 2025
Conversation
Owner
|
Thanks. I will pull this down in the next couple of days and test it. Looks good though and should be able to put this in a release soon! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where OperationResponseAssociation was not using the configured database connection and instead defaulting to 'default'. The fix ensures that the class respects the connection name specified in the configuration.
- Updated
OperationResponseAssociationconstructor to accept aConfigurationparameter - Modified the database connection retrieval to use the configured connection name instead of hardcoded 'default'
- Updated all test cases and calling code to pass the configuration parameter
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Lib/Operation/OperationResponseAssociation.php | Added Configuration parameter to constructor and updated connection retrieval logic |
| src/Lib/Operation/OperationResponse.php | Updated instantiation to pass Configuration parameter |
| tests/TestCase/Lib/Operation/OperationResponseAssociationTest.php | Added test connection configuration and updated all test instantiations |
| tests/TestCase/Lib/MediaType/JsonLdTest.php | Added test connection configuration and updated instantiations |
| tests/TestCase/Lib/MediaType/HalJsonTest.php | Added test connection configuration and updated instantiations |
| tests/test_app/src/Controller/OperationPathController.php | Updated parameter signature to use nullable type syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576