Skip to content

Conversation

carlynvandyke
Copy link

@carlynvandyke carlynvandyke commented Jan 27, 2025

Per Roni's request. Addresses #1527

Remove confirmed_7dav_cumulative_num and confirmed_7dav_cumulative_prop
Remove JHU signals from documentation
Copy link

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we should also remove the similarly-named signals from indicator-combination and usa-facts:

| `confirmed_cumulative_num` and `confirmed_7dav_cumulative_num`| Cumulative number of confirmed COVID-19 cases <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |
| `confirmed_cumulative_prop` and `confirmed_7dav_cumulative_prop`| Cumulative number of confirmed COVID-19 cases per 100,000 population <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |
| `confirmed_incidence_num` and `confirmed_7dav_incidence_num` | Number of new confirmed COVID-19 cases, daily <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |
| `confirmed_incidence_prop` and `confirmed_7dav_incidence_prop` | Number of new confirmed COVID-19 cases per 100,000 population, daily <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |
| `deaths_cumulative_num` and `deaths_7dav_cumulative_num`| Cumulative number of confirmed deaths due to COVID-19 <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |
| `deaths_cumulative_prop` and `deaths_7dav_cumulative_prop`| Cumulative number of confirmed due to COVID-19, per 100,000 population <br/> **Earliest date available:** 2020-01-25 & 2020-02-01 |

| `confirmed_cumulative_num` | `confirmed_7dav_cumulative_num` | Cumulative number of confirmed COVID-19 cases <br/> **Earliest date available:** 2020-02-20 |
| `confirmed_cumulative_prop` | `confirmed_7dav_cumulative_prop`| Cumulative number of confirmed COVID-19 cases per 100,000 population <br/> **Earliest date available:** 2020-02-20 |
| `confirmed_incidence_num` | `confirmed_7dav_incidence_num` | Number of new confirmed COVID-19 cases, daily <br/> **Earliest date available:** 2020-02-20 |
| `confirmed_incidence_prop` | `confirmed_7dav_incidence_prop` | Number of new confirmed COVID-19 cases per 100,000 population, daily <br/> **Earliest date available:** 2020-02-20 |
| `deaths_cumulative_num` | `deaths_7dav_cumulative_num` | Cumulative number of confirmed deaths due to COVID-19 <br/> **Earliest date available:** 2020-02-20 |
| `deaths_cumulative_prop` | `deaths_7dav_cumulative_prop` | Cumulative number of confirmed due to COVID-19, per 100,000 population <br/> **Earliest date available:** 2020-02-20 |

@melange396
Copy link
Collaborator

for completeness, we should also remove these two lines from a helper script:

if '7dav_cumulative' in signal:
return True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 7dav cumulative signals from JHU documentation and from the DB
2 participants