Fix: SEAs spawning as Army ranks#12150
Open
MistChristmas wants to merge 2 commits intocmss13-devs:masterfrom
Open
Fix: SEAs spawning as Army ranks#12150MistChristmas wants to merge 2 commits intocmss13-devs:masterfrom
MistChristmas wants to merge 2 commits intocmss13-devs:masterfrom
Conversation
cmss13-ci
Bot
added
Fix
realforest2001
approved these changes
May 3, 2026
github-project-automation
Bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Resolves: #12073
Only existed for SEAs because they're the only one that uses this awful proc. but just in case someone wants/needs it later, it has an option to take a list but defaults to just everything.
But because AE8 and ME8 for example share the same name, and Army ranks come before Marine ranks, it just used the Army ones. Fix that by just having a short list for USCM SEA ranks. and populating it properly when all of the paygrades get populated.
Also fix Army E9 being Master Sergeant and not Sergeant Major
Explain why it's good for the game
Army but marine bad.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: SEAs can no longer spawn with Army ranks. Fix Army E9 being Master Sergeant and not Sergeant Major
/:cl: