Small adjustment to skip BTV info for open data#46
Open
nsmith- wants to merge 1 commit intocms-jet:masterfrom
Open
Small adjustment to skip BTV info for open data#46nsmith- wants to merge 1 commit intocms-jet:masterfrom
nsmith- wants to merge 1 commit intocms-jet:masterfrom
Conversation
AnnikaStein
reviewed
Dec 7, 2022
Contributor
AnnikaStein
left a comment
There was a problem hiding this comment.
Hi @nsmith-
Thanks for the PR! From BTV-side, the changes itself look good.
For what concerns the proper place to document the functionality, you could update the PR with a small entry in the README.md where you introduce the new customization options, and put the recipe mentioned in your PR description to help users reproduce with this setup.
On the specific comments:
- jetToolbox: I'd like to pass this question on to JME, maybe @nurfikri89 knows of a jetToolbox-independent way?
NANOAOD(SIM): we agree, and should switch toNANOAODfor data, the proposed changes (using cmsDriver flag) are fine. We would actually like to port this also to the 12_4_8 branch, but this can come later in an independent PR.- 2015 Open Data era: thanks for the pointer, I think these are very interesting developments and even if they are not completely validated as you write, I see no showstopper there for PFNano. From what I understand we can go ahead with
git cms-merge-topic 39040for now as proposed.
Contributor
Author
|
Thanks for your comments! I'll add a small section to the README then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows to use the customize commands
which skip trying to add BTV info, and hence skips jet updating. This allows us to run on 2015 OpenData MiniAOD files which have AK8CHS jets instead of AK8Puppi jets, messing up any attempts to access subjet collections.
I'm going to dump here (for lack of a better place at the moment) an example recipe for setting up an opendata area:
Here are some examples of setting up configurations for processing DoubleMuon or DY records:
Lastly, they can be run with
Both run at about 10 events/s from local files, and produce output about 40% the size of the input. Skims could be implemented by using various EDFilters in front of the nano step, e.g. HLTFilter.
A few comments:
--eventcontent NANOAODSIM --datatier NANOAODSIMfor data, rather than--eventcontent NANOAOD --datatier NANOAOD. This seems to not matter but it does mess up thefakeNameForCrabmodifier. I think a better solution here would be to remove allfakeNameForCrabmodifiers frompfnano_cff.pyand instead use a cmsDriver flag:--customize_commands 'process.NANOAODSIMoutput.fakeNameForCrab = cms.untracked.bool(True)'.run2_nanoAOD_106X2015implemented in Introduced new era for 2015 opendata nanoaod processing cms-sw/cmssw#39040 is not completely validated, see the PR for more detail.