Run-3: Copied Regrouped Unc and Added L2Relative for PNet and UParT#220
Open
ravindkv wants to merge 5 commits intocms-jet:masterfrom
Open
Run-3: Copied Regrouped Unc and Added L2Relative for PNet and UParT#220ravindkv wants to merge 5 commits intocms-jet:masterfrom
ravindkv wants to merge 5 commits intocms-jet:masterfrom
Conversation
…d UParT, also added AK4PFChs for consistency
Collaborator
|
Thanks @ravindkv , looks good. I have one comment:
I also have two questions:
|
Collaborator
|
Hi @ravindkv , could you also consider removing the L2Residual files, as we had agreed to stop including them from now on? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is intended to copy the "Regrouped" uncertainty set [*] AND include the currently available L2Relative JECs for PNET/UParT for most of the years of Run-3
[Summer22_22Sep2023_V4]: Regrouped unc
[Summer22EE_22Sep2023_V4]: Regrouped unc
[Summer23Prompt23_V4]: Regrouped unc
[Summer23BPixPrompt23_V4]: Regrouped unc
[Summer24Prompt24_V3_V4]: Regrouped unc, L2Relative for PNET and UParT, also added AK4PFChs for consistency. The Residual JECs for PNET and UParT are clonned from regular jets.
Except these, all other JECs are exactly the same (symlinked to the previous versions)
cc: @izisopou
[*] originally copied from from Summer19UL18, we just change the year string name