Skip to content

Conversation

@pxsit
Copy link
Contributor

@pxsit pxsit commented Jul 23, 2025

Add a Score counter to task overview
image

@prandla
Copy link
Member

prandla commented Jul 23, 2025

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.

Does anyone else have any thoughts?

@Muaath5
Copy link

Muaath5 commented Jul 28, 2025

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.

Does anyone else have any thoughts?

I don't see any issues if both of these ways where implemented, but if it was in the task overview it would be better in case of onsite competitions and you don't want others to look into your score :)

@pxsit
Copy link
Contributor Author

pxsit commented Aug 1, 2025

I have some comments about the code, but i'm wondering if this is the UI we want in the first place... I saw some browser extension that showed the task scores on the sidebar next to the task links, maybe that would be better.
Does anyone else have any thoughts?

I don't see any issues if both of these ways where implemented, but if it was in the task overview it would be better in case of onsite competitions and you don't want others to look into your score :)

Added an option to toggle this in AWS (:

Reformat, Fix Updaters, more
@pxsit
Copy link
Contributor Author

pxsit commented Aug 4, 2025

image Im still getting this bug, let me try fix it

@pxsit
Copy link
Contributor Author

pxsit commented Aug 4, 2025

Should be fixed! (According to my testing)

@prandla
Copy link
Member

prandla commented Aug 4, 2025

Sorry, I just looked at the rest of cws_style.css, and now I think your original approach was the best... I thought the places you changed were the only places that defined these colors, but looks like there are quite a few other places that use slightly different colors, so explicitly defining that these colors are in the task overview table and in the submission list table is fine.

After reverting that it should be good to merge.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.63%. Comparing base (7e94024) to head (1134711).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/server/contest/handlers/main.py 21.05% 15 Missing ⚠️
cms/server/admin/handlers/contest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   54.66%   54.63%   -0.04%     
==========================================
  Files         335      335              
  Lines       27358    27378      +20     
==========================================
+ Hits        14956    14957       +1     
- Misses      12402    12421      +19     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 54.63% <23.80%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants