This repository was archived by the owner on Feb 21, 2025. It is now read-only.
Replace get_with_token with requests.get#13
Merged
nothingface0 merged 1 commit intodevfrom Feb 14, 2025
Merged
Conversation
The get_with_token method does not allow modifying the headers, so it was missing the custom user agent, breaking the single function that was using get_with_token.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #13 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 4 4
Lines 379 379
=======================================
Hits 362 362
Misses 17 17 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_with_token method from
cernrequestsdoes not allowmodifying the headers, so it was missing the
custom user agent, breaking the single function
that was using get_with_token.