This repository was archived by the owner on Dec 12, 2024. It is now read-only.
Allow password login#20
Open
plumdog wants to merge 3 commits intocmrigney:masterfrom
plumdog:allow_password_login
Open
Allow password login#20plumdog wants to merge 3 commits intocmrigney:masterfrom plumdog:allow_password_login
plumdog wants to merge 3 commits intocmrigney:masterfrom
plumdog:allow_password_login
Conversation
cmrigney
suggested changes
Jul 4, 2018
Owner
cmrigney
left a comment
cmrigney
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you also add a couple tests to cover this case?
| removePasswordLogin(username) { | ||
| const self = this; | ||
| _.remove(this.passwordLogins, (p) => { | ||
| self._log(util.format('Removed password login for username %s', username)); |
Owner
There was a problem hiding this comment.
Please move this log message outside of this function. It will be called for each user in the passwordLogins. It would also be useful to check that the length changed to ensure the user was actually removed.
Owner
|
Also, please update the typescript definition file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #19.
I hope this is the right approach.
Things I haven't done that might matter:
pubKeyvariable