perf: Remove ResizeObserver polyfill #154
Open
+87
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All target browsers now support native ResizeObserver API, making the polyfill unnecessary. This change reduces bundle size and simplifies the codebase. Changes: - Remove @juggle/resize-observer dependency from package.json - Replace polyfill imports with native ResizeObserver API - Update useResizeObserver to use getBoundingClientRect() for initial sync measurement - Add convertElementToEntry() helper since native ResizeObserverEntry cannot be constructed - Remove __mocks__/@juggle/resize-observer.ts mock file - Add comprehensive Jest mocks for ResizeObserver and getBoundingClientRect in test environment - Extract ResizeObserver test mocks to separate reusable module
TrevorBurnham
added a commit
to TrevorBurnham/cloudscape-components
that referenced
this pull request
Aug 24, 2025
All target browsers now support the native ResizeObserver API, making the polyfill unnecessary. This change reduces bundle size and simplifies the codebase. Changes: - Remove @juggle/resize-observer from package.json dependencies - Update sticky scrollbar hook to use native ResizeObserver - Add global ResizeObserver mock in Jest setup for JSDOM compatibility - Update mock file to use native ResizeObserver types with JSDOM-compatible implementations Note that the mock file can be removed once the polyfill is also removed from @cloudscape-design/component-toolkit: cloudscape-design/component-toolkit#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All target browsers now support the native ResizeObserver API, making the polyfill unnecessary: https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#browser_compatibility
This change reduces bundle size and simplifies the codebase.
Changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.