Minimal provider version for aws_s3_directory_bucket

[salemgolemugoo]

what

Updated AWS provider version for the new resource used in the module aws_s3_directory_bucket

why

Old provider doesn't support this resource The provider hashicorp/aws does not support resource type

references

https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5280-november-29-2023

[nitrocode]

/terratest

[nitrocode]

@Gowiem this would require a major version, right? If so, then we'd probably need to add all the non major changes first before this goes in

[Gowiem]

@nitrocode I think we are treating major provider version bumps as major module version bumps, so that sounds right 👍

[Gowiem]

Oh but @salemgolemugoo is saying that we're already using aws_s3_directory_bucket (which we are) and that resources REQUIRES v5.x of the AWS Provider... so we should've already did a major rev when we introduced that resource... damn.

@nitrocode I feel like it probably makes sense to raise this as a major rev and update all of the release docs from when that resource was added to mention that it should've included this provider rev to major. Mind taking that on?