Skip to content

feature: add credentialSpecs #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feature: add credentialSpecs #195

wants to merge 3 commits into from

Conversation

getSurreal
Copy link

what

  • Add credentialSpecs parameter

why

  • Support an AWS documented parameter.
  • Needed for gMSA service account used with Active Directory authentication

references

@getSurreal getSurreal requested review from a team as code owners June 4, 2025 14:58
@getSurreal getSurreal requested review from Gowiem and nitrocode June 4, 2025 14:58
@mergify mergify bot added the triage Needs triage label Jun 4, 2025
@getSurreal
Copy link
Author

Looks like make init and make readme functionality has been removed. Let me know what the alternative steps are.

Gowiem
Gowiem approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot removed the triage Needs triage label Jun 5, 2025
@Gowiem
Copy link
Member

Gowiem commented Jun 6, 2025

/terratest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getSurreal @Gowiem