feat: add last login filtering support to Users API #725
+45
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudinary-pkoniu
requested changes
Nov 21, 2025
Contributor
cloudinary-pkoniu
left a comment
cloudinary-pkoniu
left a comment
There was a problem hiding this comment.
Current implementation is a breaking change, it cannot be added to a minor release.
cloudinary-pkoniu
requested changes
Dec 19, 2025
types/index.d.ts
Outdated
| function user(userId: string, options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>; | ||
|
|
||
| function users(pending: boolean, userIds?: string[], prefix?: string, subAccountId?: string, options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>; | ||
| function users(pending: boolean, userIds?: string[], prefix?: string, subAccountId?: string, lastLogin?: boolean, fromDate?: Date | string, toDate?: Date | string, options?: ProvisioningApiOptions, callback?: ResponseCallback): Promise<any>; |
Contributor
There was a problem hiding this comment.
Move lastLogin, fromDate and toDate to options object.
Also, extend the typescript definition of the options object, so it includes those fields and its types.
Keep in mind that it should be backwards compatible, so we aim towards extending the contract rather then changing it. Options could look like this:
function users(..., options?: ProvisioningApiOptions | { lastLogin?: boolean; fromDate?: Date | string; toDate?: Date | string })
Contributor
Author
There was a problem hiding this comment.
Updated as requested, to ensure backward compatibility. I moved the new parameters into the options object and updated the typescript definition to include those new fields in options.
All checks passed.
…red users function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
What Does This PR Address?
Are Tests Included?
Reviewer, Please Note: