[v8] IT improvement: Use http.DefaultTransport.Clone() in UAA version check
#3643
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual http.Transport creation with cloning DefaultTransport to preserve default transport settings while configuring TLS.
anujc25
force-pushed
the
default-transport-fix-it
branch
2 times, most recently
from
344d92b to
d87720c
Compare
anujc25
changed the title
http.DefaultTransport.Clone() in UAA version checkhttp.DefaultTransport.Clone() in UAA version check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Replace manual http.Transport creation with cloning DefaultTransport to preserve default transport settings while configuring TLS.
Why Is This PR Valuable?
When running the tests against an environment which is behind proxy and running tests by setting https_proxy env the existing test does not respect the proxy configuration mainly because it create a separate transport object instead of cloning from the DefaultTransport.
This PR solve that issue.
Applicable Issues
#3653
How Urgent Is The Change?
Not urgent
Other Relevant Parties
N/A