Remove duplicate glowing effect components - #38
Merged
wiatrM merged 1 commit intoJul 31, 2025
Conversation
Co-authored-by: mwiatr.dev <mwiatr.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an inline comment to document the removal of accidentally duplicated GlowingEffect wrappers in EnhancedProjects.
- Documents the previous two-layer wrapping and the corrected single wrapper.
- Provides context for future debugging but does not change runtime behavior.
Comments suppressed due to low confidence (1)
components/enhanced-projects-heavy.tsx:160
- [nitpick] Consider removing or minimizing this inline comment and instead documenting the bug fix in the commit message or a CHANGELOG. Long historical notes in JSX can clutter component code and are often better kept in version control history.
{/*
Comment on lines
+161
to
+169
| BUG FIX: Removed duplicate GlowingEffect components | ||
| Previously there were two identical GlowingEffect components: | ||
| <GlowingEffect glow={true} disabled={false} borderWidth={1}> | ||
| <GlowingEffect glow={true} disabled={false} borderWidth={1}> | ||
| <Card>...</Card> | ||
| </GlowingEffect> | ||
| </GlowingEffect> | ||
|
|
||
| Now correctly wrapped with only one GlowingEffect: |
There was a problem hiding this comment.
[nitpick] If you choose to retain an inline note, consider using a consistent comment style (e.g., JSDoc) or a shorter heading (like NOTE:) to align with project conventions and improve readability.
Suggested change
| BUG FIX: Removed duplicate GlowingEffect components | |
| Previously there were two identical GlowingEffect components: | |
| <GlowingEffect glow={true} disabled={false} borderWidth={1}> | |
| <GlowingEffect glow={true} disabled={false} borderWidth={1}> | |
| <Card>...</Card> | |
| </GlowingEffect> | |
| </GlowingEffect> | |
| Now correctly wrapped with only one GlowingEffect: | |
| NOTE: Removed duplicate GlowingEffect components. | |
| Previously, two identical GlowingEffect components were nested. | |
| Now correctly wrapped with a single GlowingEffect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a comment illustrating the fix for a reported duplicate
GlowingEffectcomponent.The
GlowingEffectcomponent was not found in the codebase during the investigation. This comment serves to document the correct approach for handling such a duplication, should it arise.