Skip to content

add build command to cf-wrangler#14340

Merged
emily-shen merged 2 commits into
mainfrom
emily/cf-wrangler-build
Jun 17, 2026
Merged

add build command to cf-wrangler#14340
emily-shen merged 2 commits into
mainfrom
emily/cf-wrangler-build

Conversation

@emily-shen

@emily-shen emily-shen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Adds a cf-wrangler build command that always produces something that works with the build output api.

Also sneaking in another change - adding skipLastDeployedFromApiCheck to deploy-helpers, so that we can skip the deploy source check in cf. cf is not recognised by EWC, so it always gets normalised to api. cf also always turns on strict mode, so this check would then always fail.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal features

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a5e3a8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Minor
@cloudflare/deploy-helpers Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 17, 2026
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team June 17, 2026 13:50
@workers-devprod

workers-devprod commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk

ask-bonk Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@emily-shen Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Issues found

.changeset/fancy-crabs-occur.md

  1. Changelog Quality: The description is too terse. It states what was added (skipLastDeployedFromApiCheck) but does not explain the reason for the change, what problem it solves, or how users should use the new option. Please expand the body to include the motivation and any relevant usage details.

  2. Version Type: Adding a new configuration option generally warrants a minor bump per the changeset guidelines ("new configuration options" are listed under minor). While this could be a bug fix in certain contexts, please confirm that patch is the correct choice here.

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14340

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14340

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14340

miniflare

npm i https://pkg.pr.new/miniflare@14340

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14340

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14340

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14340

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14340

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14340

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14340

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14340

wrangler

npm i https://pkg.pr.new/wrangler@14340

commit: a5e3a8f

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 17, 2026
@emily-shen emily-shen added the ci:skip-pr-description-validation Skip validation of the required PR description format label Jun 17, 2026
@emily-shen emily-shen merged commit f6e49dd into main Jun 17, 2026
83 of 86 checks passed
@emily-shen emily-shen deleted the emily/cf-wrangler-build branch June 17, 2026 14:29
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants