Skip to content

feat: workerd build target#14338

Draft
edmundhung wants to merge 5 commits into
mainfrom
edmundhung/vite-workerd-target
Draft

feat: workerd build target#14338
edmundhung wants to merge 5 commits into
mainfrom
edmundhung/vite-workerd-target

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Fixes #[insert GH or internal issue link(s)].

Just a quick prototype. Not meant to be merged.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6b3f7ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk

ask-bonk Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@edmundhung Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14338

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14338

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14338

miniflare

npm i https://pkg.pr.new/miniflare@14338

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14338

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14338

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14338

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14338

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14338

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14338

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14338

wrangler

npm i https://pkg.pr.new/wrangler@14338

commit: 6b3f7ba

@ask-bonk

ask-bonk Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I've reviewed enough. The PR is an explicit prototype ("Just a quick prototype. Not meant to be merged."). The code degrades gracefully on the intended path (unstable_assembleWorkerdConfigunstable_getConfig + dispose).

Let me do a final check on one potential real bug: in the vite plugin, getWorkerConfigs is called for ALL workers, including the prerender config. But more importantly, the name: options.name ?? workerConfig.nameworkerConfig.name could be undefined per Unstable_Config. That's a minor robustness issue, not a clear bug.

The substantive issues I found are all on non-prototype paths that aren't reached by the intended flow. Given the explicit prototype framing and pragmatic review guidelines, there are no actionable issues that would block this prototype on its intended path. The only genuinely useful note is the #runtimeEntryURL assertion making ready/getURL/dispatchFetch throw in workerd-output mode — but that's by design for this mode and not used by the intended entry point.

There are no concrete, actionable bugs on the code paths this PR is meant to exercise.

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants