[wrangler] Surface API error notes in "Some triggers failed to deploy" message#14333
Open
Divkix wants to merge 1 commit into
Open
[wrangler] Surface API error notes in "Some triggers failed to deploy" message#14333Divkix wants to merge 1 commit into
Divkix wants to merge 1 commit into
Conversation
…' message When a trigger (workflow, schedule, custom domain) fails to deploy, the underlying APIError/ParseError notes (e.g. cron_requires_paid_plan) are now appended to the aggregated error message instead of being dropped, so users see the real cause without needing WRANGLER_LOG=debug.
🦋 Changeset detectedLatest commit: 0feec78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
emily-shen
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14288.
When a trigger (workflow, schedule, or custom domain) fails to deploy, Wrangler previously surfaced only the generic aggregated message:
The actual reason returned by the API (e.g.
cron_requires_paid_plan) was dropped, and only visible viaWRANGLER_LOG=debug. This happened because the aggregated message was built fromerror.messageonly — but these areAPIError(extendsParseError), whose.message/.textis just the generic "A request to the Cloudflare API (...) failed." string. The real details live in.notes[], populated bythrowFetchError.This change surfaces those notes directly in the aggregated "Some triggers failed to deploy" message (for
APIError/ParseErrorcauses), so users immediately see the underlying reason. The existing telemetry aggregation is unchanged.