proposal: use three block style for use declarations#80
Merged
AkshatM merged 2 commits intocloudflare:mainfrom Apr 23, 2026
Merged
proposal: use three block style for use declarations#80AkshatM merged 2 commits intocloudflare:mainfrom
AkshatM merged 2 commits intocloudflare:mainfrom
Conversation
AkshatM
approved these changes
Apr 22, 2026
This now sorts use declarations in blocks, which is a widely used style. The first block is for std, core, and alloc. The second one is for external crates. The third one is for crate internal use declarations.
Contributor
|
Thank you for your contributions, @valkum ! They are much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now sorts use declarations in blocks, which is a widely used style and provides a better overview of external vs internal "uses".
The first block is for std, core, and alloc. The second one is for external crates. The third one is for crate internal use declarations.
I checked other Cloudflare Rust repos. In multiple repos, there are files that follow this style, but there are also a lot of files that do not. Some seem to have three blocks in a different order (std, internal, external). I, personally, think it improves readability. If you do not agree, feel free to just close this PR.
This PR is based on a comment on #74 (comment)