Replace once_cell with std LazyLock and OnceLock #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSRV bump to 1.83 enables using standard library equivalents. This removes the external once_cell dependency. Changes: - Replace once_cell::sync::Lazy with std::sync::LazyLock - Replace once_cell::sync::OnceCell with std::sync::OnceLock - Update try_insert() pattern in pingora-runtime to use set() - Remove once_cell from workspace and crate dependencies Fixes cloudflare#721
Address clippy lints that were failing in CI: - Replace map_or(true, ...) with is_none_or() per clippy::unnecessary_map_or - Replace io::Error::new(io::ErrorKind::Other, e) with io::Error::other(e) - Fix cfg gate on wait_for_peer to match its only caller - Add cfg gates to imports only used in Linux-specific tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSRV bump to 1.83 enables using standard library equivalents. This removes the external once_cell dependency.
Changes:
Fixes #721