-
Notifications
You must be signed in to change notification settings - Fork 402
[docs] modernize Apple Silicon instructions, clarify Python 3.11 support, remove Intel Mac references #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the installation documentation to modernize instructions by adding support for Python 3.11 and updating the guidance for Apple Silicon devices. The key changes include:
- Adding Python 3.11 as a supported version and updating related environment variable examples.
- Replacing Intel Mac references with Apple Silicon (M1, M2, M3) terminology.
- Updating installation instructions and command paths to reflect these changes.
Comments suppressed due to low confidence (1)
docs/docs-site/content/administrator/installation/dependencies/_index.md:236
- [nitpick] Consider explicitly aligning this note with the supported Python versions listed at the beginning of the document to ensure clarity about which versions are recommended and how installation instructions differ for each.
***Note:** By default, Hue will use the highest available Python version on your system. If you want to use a lower Python version (e.g., Python 3.8 or 3.9), set the `PYTHON_VER` environment variable before building. For Python 3.11, use `./build/env/bin/hue` as the command path. For Python versions lower than 3.11, the command path will be `./build/venvs/python3.x/bin/hue`, where `python3.x` matches your `PYTHON_VER` setting. Both options will work as long as you use the correct path for your Python version.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I've left some review comments
docs/docs-site/content/administrator/installation/dependencies/_index.md
Show resolved
Hide resolved
docs/docs-site/content/administrator/installation/dependencies/_index.md
Outdated
Show resolved
Hide resolved
360ccdc
to
2756efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ort, remove Intel Mac references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What changes were proposed in this pull request?
How was this patch tested?