-
Notifications
You must be signed in to change notification settings - Fork 402
[docs] Expand and update File Import API documentation #4152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates and expands the documentation for the File Import API, providing a comprehensive guide with detailed endpoint descriptions, request parameters, examples, and a complete workflow for importing files.
- Expanded overview and introduction for the API
- Detailed endpoint documentation with request/response examples and parameter tables
- A complete workflow example consolidating multiple API calls
Comments suppressed due to low confidence (1)
docs/docs-site/content/developer/api/rest/_index.md:575
- [nitpick] Consider using a more descriptive heading (e.g., 'File Importer') instead of the generic 'Importer' to align with the API naming in the endpoints.
## Importer
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we should let someone try it all out using this manual? Perhaps let an AI have a go and see if the docs is enough for it to get it right?
From GeminiBlind Spots or Unclear Aspects: Handling of delimiter_format for file_type: In the Guess File Header and Preview File endpoints, file_type can be delimiter_format. However, the documentation doesn't explicitly describe what "delimiter_format" entails or how it might differ from csv or tsv in terms of required parameters (e.g., if field_separator is mandatory). record_separator in preview endpoint: The preview endpoint has record_separator as an optional parameter with a default of \n. While field_separator and quote_char are clearly derived from guess_metadata for CSV/TSV, it's not explicitly stated if record_separator also comes from guess_metadata or if it's always assumed to be \n. The guess_metadata response for CSV/TSV does include record_separator, so it would be good to explicitly state that it should be passed to preview if desired. |
Added required changes. |
…orkflows and add a new Docs Lint workflow for improved link checking
…endpoints, workflows, and examples
d391c49
to
4d477b2
Compare
What changes were proposed in this pull request?
How was this patch tested?