Skip to content

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • Provides a comprehensive, step-by-step guide for the File Import API, detailing endpoints, parameters, example requests, and responses.
  • Clarifies the import workflow and adds documentation for features like metadata detection, header guessing, previewing, and SQL type mapping.
  • Improves clarity and usefulness for developers integrating file import functionality.

How was this patch tested?

  • Manually

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates and expands the documentation for the File Import API, providing a comprehensive guide with detailed endpoint descriptions, request parameters, examples, and a complete workflow for importing files.

  • Expanded overview and introduction for the API
  • Detailed endpoint documentation with request/response examples and parameter tables
  • A complete workflow example consolidating multiple API calls
Comments suppressed due to low confidence (1)

docs/docs-site/content/developer/api/rest/_index.md:575

  • [nitpick] Consider using a more descriptive heading (e.g., 'File Importer') instead of the generic 'Importer' to align with the API naming in the endpoints.
## Importer

Copy link

github-actions bot commented May 30, 2025

⚠️ No test files modified. Please ensure that changes are properly tested. ⚠️

Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Documentation.

Copy link

github-actions bot commented May 30, 2025

Python Code Coverage

Python Coverage Report •
FileStmtsMissCoverMissing
TOTAL541852707850% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1186 106 💤 0 ❌ 0 🔥 5m 54s ⏱️

Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should let someone try it all out using this manual? Perhaps let an AI have a go and see if the docs is enough for it to get it right?

@bjornalm
Copy link
Collaborator

From Gemini

Blind Spots or Unclear Aspects:

Handling of delimiter_format for file_type: In the Guess File Header and Preview File endpoints, file_type can be delimiter_format. However, the documentation doesn't explicitly describe what "delimiter_format" entails or how it might differ from csv or tsv in terms of required parameters (e.g., if field_separator is mandatory).

record_separator in preview endpoint: The preview endpoint has record_separator as an optional parameter with a default of \n. While field_separator and quote_char are clearly derived from guess_metadata for CSV/TSV, it's not explicitly stated if record_separator also comes from guess_metadata or if it's always assumed to be \n. The guess_metadata response for CSV/TSV does include record_separator, so it would be good to explicitly state that it should be passed to preview if desired.

@Harshg999
Copy link
Collaborator Author

From Gemini

Blind Spots or Unclear Aspects:

Handling of delimiter_format for file_type: In the Guess File Header and Preview File endpoints, file_type can be delimiter_format. However, the documentation doesn't explicitly describe what "delimiter_format" entails or how it might differ from csv or tsv in terms of required parameters (e.g., if field_separator is mandatory).

record_separator in preview endpoint: The preview endpoint has record_separator as an optional parameter with a default of \n. While field_separator and quote_char are clearly derived from guess_metadata for CSV/TSV, it's not explicitly stated if record_separator also comes from guess_metadata or if it's always assumed to be \n. The guess_metadata response for CSV/TSV does include record_separator, so it would be good to explicitly state that it should be passed to preview if desired.

Added required changes.

Harshg999 added 2 commits May 31, 2025 00:22
…orkflows and add a new Docs Lint workflow for improved link checking
@Harshg999 Harshg999 force-pushed the add-importer-api-docs branch from d391c49 to 4d477b2 Compare May 30, 2025 18:57
@Harshg999 Harshg999 merged commit d1b23e4 into master May 30, 2025
9 checks passed
@Harshg999 Harshg999 deleted the add-importer-api-docs branch May 30, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants