-
Notifications
You must be signed in to change notification settings - Fork 397
When requesting sample data for partition column, the partition are not enclosed properly #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quadoss
wants to merge
2
commits into
master
Choose a base branch
from
sample_partition_column
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not enclosed properly Internal Jira: CDPD-65130 Steps to reproduce the issue: CREATE External TABLE test_partiton_sample_record (id INT ,test STRING) PARTITIONED BY (InsertDate VARCHAR(10)); Alter table test_partiton_sample_record add partition (InsertDate='2023-01-01') Alter table test_partiton_sample_record add partition (InsertDate='2023-02-01') Insert into test_partiton_sample_record PARTITION(InsertDate'2023-01-01') VALUES (2,'test') Insert into test_partiton_sample_record PARTITION(InsertDate'2023-02-01') VALUES (1,'test') On the hue page, go to hive editor, click the table "!" mark and see the sample data is no loaded Go into the table browser and switch to the sample page, found the sample data is not displayed too. The issue is because when considering the partition we check only from exact value but if it has a format like CHAR(1) we do not consider it as a CHAR and set this up with the below which will not return any records. select * test_partiton_sample_record WHERE (`InsertDate`=2023-02-01) OR (`InsertDate`=2023-01-01) LIMIT 100
amitsrivastava
approved these changes
Jan 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Jira: CDPD-65130
Steps to reproduce the issue:
CREATE External TABLE test_partiton_sample_record (id INT ,test STRING) PARTITIONED BY (InsertDate VARCHAR(10));
Alter table test_partiton_sample_record add partition (InsertDate='2023-01-01') Alter table test_partiton_sample_record add partition (InsertDate='2023-02-01')
Insert into test_partiton_sample_record PARTITION(InsertDate'2023-01-01') VALUES (2,'test') Insert into test_partiton_sample_record PARTITION(InsertDate'2023-02-01') VALUES (1,'test')
On the hue page, go to hive editor, click the table "!" mark and see the sample data is no loaded Go into the table browser and switch to the sample page, found the sample data is not displayed too.
The issue is because when considering the partition we check only from exact value but if it has a format like CHAR(1) we do not consider it as a CHAR and set this up with the below which will not return any records.
select * test_partiton_sample_record WHERE (
InsertDate
=2023-02-01) OR (InsertDate
=2023-01-01) LIMIT 100What changes were proposed in this pull request?
Add in a strip condition to get the needed information and then perform the validation
How was this patch tested?
Manually