-
Notifications
You must be signed in to change notification settings - Fork 7
Support External Postgres DB #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
d9498ef
ai generated tests for the evaluators functions
jkwatson 9677012
don't try to look up node ids in empty vector stores
jkwatson 49bbdb1
move suggested questions under the sessions route
jkwatson 19f0f43
fix things up for postgres db access
jkwatson b0c6f3c
formatting
jkwatson 50c1f3f
fixes for not being able to create new dbs
jkwatson b343124
only set the DB_URL if it isn't already set
jkwatson 77e14e1
fix the install directory
jkwatson 0d83634
change location of .nvm and source bash from install_node
ewilliams-cloudera cd202de
Update release version to dev-testing
actions-user 3b91002
removed unused import
ewilliams-cloudera 159b37d
add logging for initializing the JDBI instance
jkwatson 1150fbc
Update release version to dev-testing
actions-user 51b6337
wip on ui for metadata
ewilliams-cloudera af8d53f
wip
jkwatson 3ebf3c5
update FE types to match python land
jkwatson d10843b
fix margin bottom consistency
ewilliams-cloudera c3f2e2e
Update release version to dev-testing
actions-user 497c80b
set the username/password for the database if set from env
jkwatson 0c9b0a2
drop databases
mliu-cloudera c3de72a
Update release version to dev-testing
actions-user 3f7ac6e
limit number of retries
ewilliams-cloudera 7d4ebfd
Update release version to dev-testing
actions-user 168e79d
bumped bedrock converse and fixed a bug in tool calling check
baasitsharief b7f61af
remove unused
ewilliams-cloudera 1239b59
Update release version to dev-testing
actions-user 40b80c7
minor error handling improvement
ewilliams-cloudera 0420092
fixed bug with Empty Response with no documents in data source and to…
baasitsharief 4b27d11
fix mypy issues
baasitsharief 9fe4cd2
add a main method to test if a db connection string is valid
jkwatson b1a5b48
Update release version to dev-testing
actions-user 80c55b6
add python endpoint to test a jdbc connection string
jkwatson 29f635a
export the install dir so it can be used by the fastapi process
jkwatson 7f96771
make sure to use the right java
jkwatson 336fc40
pass in the db type so we can do a bare server connection
jkwatson eb50cea
Update release version to dev-testing
actions-user 41da0cf
better error handling for api proxy
ewilliams-cloudera 019e04f
pass through error on non-502s, use 502 error instaed of 503, dont re…
ewilliams-cloudera 809020b
Update release version to dev-testing
actions-user 4d0b691
more config details
ewilliams-cloudera 411e398
wip settings page for external metadata db
baasitsharief 2069e16
fix
baasitsharief 8b7bf34
drop databases
mliu-cloudera ffc56c7
wip on formatting warnings
jkwatson 3edbb91
wip
ewilliams-cloudera fc809f7
wip test connection
baasitsharief 4aefce8
update form items
ewilliams-cloudera a3e832c
fix connection test
ewilliams-cloudera 2d2b39b
use formValues
ewilliams-cloudera c0c1ab4
refactor: make username and password required for JDBC connection
baasitsharief 56199c7
improve handling for testing connection
ewilliams-cloudera 8875d10
conditionally render test button
ewilliams-cloudera d8ec481
fix mypy issues
ewilliams-cloudera 8487d7b
disable test button if no password or username
ewilliams-cloudera d0ea0cf
Update ui/src/pages/Settings/MetadataDBFields.tsx
ewilliams-cloudera 5be6d10
Update ui/src/pages/Settings/MetadataDBFields.tsx
ewilliams-cloudera 24880bd
Update release version to dev-testing
actions-user b95de5d
handle clearing values for external db when switching to h2
ewilliams-cloudera fdc3df1
clear field values in ui when using h2
ewilliams-cloudera d718e97
Update release version to dev-testing
actions-user 43c4b8d
refactor environment variable handling for H2 database configuration
ewilliams-cloudera 39ad030
Update release version to dev-testing
actions-user 5953591
refactor: update H2 database URL to use absolute path
baasitsharief 5dc9c57
refactor: change metadata_db_provider comparison to string literal fo…
baasitsharief 9e008a0
refactor: fix comparison operator for metadata_db_provider in H2 check
baasitsharief 7bb9391
Update release version to dev-testing
actions-user e91cef1
refactor: remove DB_URL, DB_USERNAME, and DB_PASSWORD from environmen…
baasitsharief 016f5df
Update release version to dev-testing
actions-user 2e71996
refactor: update config_to_env to use Optional for environment variab…
baasitsharief cb8c84d
refactor: change config_to_env to return non-optional environment var…
baasitsharief b7277e4
Update release version to dev-testing
actions-user c9088a1
refactor: update DB_URL retrieval to use a fallback value for H2 conf…
baasitsharief e422d60
refactor: streamline JDBC configuration for H2 by using a default DB_…
baasitsharief 6fc709b
refactor: improve validation message handling and remove messageQueue…
ewilliams-cloudera a65a696
Update release version to dev-testing
actions-user 5c1a97b
refactor: enhance input validation for JDBC URL, username, and passwo…
baasitsharief 3d32576
Vite dev changes to maybe address import error in dev, switch to usin…
ewilliams-cloudera 6f52f0c
Update release version to dev-testing
actions-user 4057375
test config change
ewilliams-cloudera cb83f97
Update release version to dev-testing
actions-user 8877267
title change
ewilliams-cloudera 0ccfb93
remove restriction on username
ewilliams-cloudera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why limit the username to 16 characters? Not sure we need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure if alphanumeric usernames are the right restriction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RDS has these constraints when me and Liu searched it.