Skip to content

corresponding changes for https://github.com/cloudera-labs/terraform-… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

corresponding changes for https://github.com/cloudera-labs/terraform-… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ module "cdp_aws_prereqs" {

module "cdp_deploy" {
source = "git::https://github.com/cloudera-labs/terraform-cdp-modules.git//modules/terraform-cdp-deploy?ref=v0.2.0"

env_prefix = var.env_prefix
infra_type = "aws"
region = var.aws_region
keypair_name = var.aws_key_pair
deployment_template = var.deployment_template

cdp_lb_subnet_ids = var.cdp_lb_subnet_ids
# From pre-reqs module output
aws_vpc_id = module.cdp_aws_prereqs.aws_vpc_id
aws_public_subnet_ids = module.cdp_aws_prereqs.aws_public_subnet_ids
Expand Down
2 changes: 2 additions & 0 deletions aws/terraform.tfvars.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,7 @@ ingress_extra_cidrs_and_ports = {
# cdp_public_subnet_ids=["<ENTER_EXISTING_PUBLIC_SUBNET_ID>","<ENTER_EXISTING_PUBLIC_SUBNET_ID>"] # List of pre-existing public subnet ids. Required if create_vpc is false
# cdp_private_subnet_ids=["<ENTER_EXISTING_PRIVATE_SUBNET_ID>,<ENTER_EXISTING_PRIVATE_SUBNET_ID>"] # List of pre-existing private subnet ids. Required if create_vpc is false

# cdp_lb_subnet_ids=["<ENTER_EXISTING_PRIVATE_SUBNET_ID>,<ENTER_EXISTING_PRIVATE_SUBNET_ID>"] # List of pre-existing private subnets to be used for Load Balancer targeting. If provided LBs will be placed in these subnets. Only required when deployment type is PRIVATE

# ------- Optional inputs for Control Plane Connectivity in fully private environment -------
# private_network_extensions=true # Set to false if external networking connectivity to CDP Control Plane exists
8 changes: 7 additions & 1 deletion aws/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,17 @@ variable "cdp_private_subnet_ids" {
default = null
}

variable "cdp_lb_subnet_ids" {
type = list(any)
description = "List of subnet ids for Load Balancer. Required if we want to target subnets for LB"

default = null
}
# ------- Optional inputs for Control Plane Connectivity in fully private environment -------
variable "private_network_extensions" {
type = bool

description = "Enable creation of resources for connectivity to CDP Control Plane (public subnet and NAT Gateway) for Private Deployment. Only relevant for private deployment template"

default = true
}
}