client-api: Pause time in websocket timeout tests - #3896
Merged
Conversation
Using `#[tokio::test(start_paused = true)]` pauses time, yet tokio will still advance it when encountering `sleep`s while it has no other work to do. This makes the tests that rely on timeouts deterministic and should prevent those tests from becoming flaky on busy machines.
gefjon
approved these changes
Dec 17, 2025
Collaborator
|
I trust Phoebe's review. I wouldn't know what to look for. |
kim
enabled auto-merge
December 17, 2025 19:39
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 17, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
#[tokio::test(start_paused = true)]pauses time, yet tokio will still advance it when encounteringsleeps while it has no other work to do.This makes the tests that rely on timeouts deterministic and should prevent those tests from becoming flaky on busy machines.
Expected complexity level and risk
2
Testing
This modifies tests.
It does appear to work as described, but it can't hurt if the reviewers convince themselves that it does indeed.