Resolve algebraic type refs recursively for view type check - #3876
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/fix/views-nested-types
branch
from
December 12, 2025 01:54
ceff185 to
0fd4047
Compare
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/fix/views-nested-types
branch
2 times, most recently
from
December 12, 2025 03:26
1e3fac2 to
18fe4ea
Compare
joshua-spacetime
force-pushed
the
joshua/fix/views-nested-types
branch
from
December 12, 2025 04:49
3e5e7c4 to
fbc820e
Compare
joshua-spacetime
marked this pull request as ready for review
December 12, 2025 04:55
bfops
added
release-any
jsdt
approved these changes
Dec 17, 2025
joshua-spacetime
enabled auto-merge
December 18, 2025 00:50
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Resolves algebraic type refs recursively in order to check the product type of a query builder view.
This should fix the issue reported here. However I've so far been unsuccessful in trying repro it.
Also adds further commentary to
Typespace::resolveto make it clear that it is not recursive.API and ABI breaking changes
None
Expected complexity level and risk
0
Testing
TODO. So far I haven't been able to repro with a smoketest