-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add integration tests for tpchgen-cli
#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tpchgen-cli
tpchgen-cli
FYI @@mrendi29 as well |
The new tests are run as part of CI. Here is an example: |
Thanks @alamb for taking a stab at this. @kevinjqliu i recall you had some test that you had not pushed yet, so question to you both, do we want to build off the integration tests suite within this branch/PR or should we split this into multiple PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think we can build from this integration test and then add the "check the output parquet file format"
|
Thank you @clflushopt 🙏 When you say "two sources of truth" I wonder what you mean? Do you mean some way to verify that the actual values written into the .parquet are are correct? The tests in this PR do not do that (as you note) |
Yes one for the |
Filed #161 to track |
Thanks again @clflushopt |
Rationale
As we make changes to tpchgen-cli, we need some way to test that our changes are correct.
Let's add some tests
Changes
Add CLI based tests using
assert_cmd
THis was partly written by GPT 4.0 / Github copilot