-
Notifications
You must be signed in to change notification settings - Fork 357
feat(localization): extend ru-RU localization #5698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(localization): extend ru-RU localization #5698
Conversation
|
@ZharaskhanAman is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
Hello 👋 We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days. Thanks for being a part of the Clerk community! 🙏 |
📝 WalkthroughWalkthroughThe update enhances the Russian localization file by providing Russian translations for previously undefined or untranslated UI strings. These include placeholders, labels, buttons, section headers, messages, and hints across authentication, billing, user profile, navigation, and waitlist features. No changes were made to exported or public entity declarations. Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/localizations/src/ru-RU.ts (2)
718-718
: Consider refining “Доступные опции”
In the context of payment methods, “Опции” can feel generic; you may want to use “Доступные способы оплаты” for greater clarity.
857-857
: Consider standardizing the navbar “billing” label
Using “Счет” for billing may be interpreted as a single invoice. Verify if “Оплата” or “Счета” aligns better with your UX conventions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/localizations/src/ru-RU.ts
(7 hunks)
🔇 Additional comments (13)
packages/localizations/src/ru-RU.ts (13)
85-100
: Verify placeholder and label consistency
The added input placeholders and the accompanying label for automatic invitations are well localized and follow the imperative style. Ensure that sample domain/email placeholders (example.com
,[email protected]
) intentionally remain in English to avoid confusion.
500-507
: Approve join-waitlist button additions
The newactionLink__join_waitlist
and its corresponding promptactionText__join_waitlist
are correctly translated and consistent with other CTAs.
510-511
: Approve sign-in title updates
The updatedtitle
andtitleCombined
for the sign-in start screen accurately reflect the intended flows (“Войти” vs. “Продолжить”).
516-516
: Approve corrected TOTP MFA title
Changing to “Двухфакторная верификация” fixes the typo and aligns with other MFA labels.
580-584
: Approve waitlist CTAs in restricted access
The new waitlist button and subtitle in the restricted-access block are clear, correctly worded, and offer a helpful user prompt.
785-788
: Approve enterprise SSO link localization
TheformButton
,formSubtitle
, and hint text for the enterprise SSO flow are consistent with other prompts and correctly localized.
704-710
: Approve payment-source action labels
The Russian translations for “Make default”, “Remove”, “Add new payment method”, “Cancel”, and the primary buttons are accurate and clear.
712-717
: Approve payment-source removal dialog
The removal dialog messages and titles are correctly translated and provide clear guidance on the consequences.
721-724
: Approve billing page section headers
Translations forinvoices
,paymentSources
,plans
, andsubscriptions
headers accurately match their English counterparts.
727-727
: Request translation context for subscription default action
The label “Управление” undersubscriptionsSection.actionLabel__default
may actually represent “Default” rather than “Manage.” Please confirm the intended action and adjust if necessary.
729-729
: Approve billing page title
“Счета и платежи” correctly conveys “Invoices & payments.”
1011-1016
: Approve waitlist start screen
All new labels and button texts for the waitlist start flow are accurately localized and user-friendly.
1018-1021
: Approve waitlist success screen
The success message, subtitle, and title provide a smooth onboarding experience and are well translated.
Description
Extended ru-RU localization
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit
New Features
Bug Fixes