Fixes TypeError: __init__() got an unexpected keyword argument 'firefox_options'

[abhinav-bhardwaj]

Fixes #100

Tested on
Selenium Version - 4.0.0
scrapy-selenium version - 0.0.7
Scrapy version - 2.5.1
Python version - 3.8
OS - Ubuntu 20.04.2 LTS

[RomanBukin]

I want to use options (for example, '-headless'), but now they are ignored.

[abhinav-bhardwaj]

I want to use options (for example, '-headless'), but now they are ignored.

Did you try the latest code update that I have committed?

[Zincious]

Thanks for this, works like a charm after the file change.

[RomanBukin]

Did you try the latest code update that I have committed?

Yes, now it works. Thanks.

[damienkilgannon]

While waiting on this to be merged ... which version of selenium & scrapy-selenium don't have this issue? thanks

[KonstantinKlepikov]

so, problem is in selenium version:

the browser option parameter firefox_options was deprecated in Selenium 3.8.0

If you use newest version: i tested the package today - the problem is in place.

[k0mmsussert0d]

Hello! Any chance for this to get merged?

[samlexxy]

@clemfromspace any idea when this will be merged and updated?

[wunewww]

This PR should be merged as soon as possible. it is critical. ^ ^

[samlexxy]

@abhinav-bhardwaj can you please review and merge this?

[abhinav-bhardwaj]

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

[samlexxy]

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

perhaps @clemfromspace will be kind enough to look into this

[ahmedraxa23]

self.driver = driver_klass(**driver_kwargs)
TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path'
ANY SOLUTUION?

[samlexxy]

self.driver = driver_klass(**driver_kwargs) TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

you'll need to edit your scrapy_selenium middle file..

follow this link https://github.com/clemfromspace/scrapy-selenium/pull/101/files