update cleanlab-tlm package to support binary evals #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1503
commented
Oct 28, 2025
src/cleanlab_tlm/utils/rag.py
Outdated
| query_identifier: Optional[str] = None, | ||
| context_identifier: Optional[str] = None, | ||
| response_identifier: Optional[str] = None, | ||
| mode: Optional[str] = "numeric", |
Member
|
missing unit tests |
jwmueller
reviewed
Nov 6, 2025
Co-authored-by: Jonas Mueller <[email protected]>
Contributor
Author
Added here |
Co-authored-by: Aditya Thyagarajan <[email protected]> Co-authored-by: Jonas Mueller <[email protected]>
Member
|
What's going on with the formatting check in the CI? |
elisno
reviewed
Dec 4, 2025
Comment on lines
-10
to
-11
| trustworthy_rag, # noqa: F401 | ||
| trustworthy_rag_api_key, # noqa: F401 |
Member
There was a problem hiding this comment.
Why did you remove these? These fixtures are not defined in conftest.py, so they need to be imported.
Member
There was a problem hiding this comment.
Why is this file being updated at all?
Contributor
Author
There was a problem hiding this comment.
This was with hatch automatic format fix, I'll look into these
| # Compile and validate the eval | ||
| self.mode = self._compile_mode(mode, criteria, name) | ||
|
|
||
| def _compile_mode(self, mode: Optional[str], criteria: str, name: str) -> str: |
Member
There was a problem hiding this comment.
This _compile_mode method needs to be written more carefully to avoid unintentionally breaking all our tests. A lot of the userwarnings will be thrown as errors during automated testing.
aditya1503
commented
Dec 4, 2025
| # Compile and validate the eval | ||
| self.mode = self._compile_mode(mode, criteria, name) | ||
|
|
||
| def _compile_mode(self, mode: Optional[str], criteria: str, name: str) -> str: |
Contributor
Author
There was a problem hiding this comment.
Add separate test cases for these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces mode for TLM RAG evals Binary/continuous
merge after backend PR