feat: use ukiryu as command API for inkscape and ghostscript #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a SystemCommand module to centralize cross-platform command execution concerns.
Changes
Create
SystemCommandmodule with three main utilities:format_path: Format paths for command execution (Windows backslash conversion + quoting)headless_environment: Get env vars for headless operation (disable DISPLAY on Unix)find_executable: Find executables in PATH with PATHEXT handlingRefactor
InkscapeWrapperto use:SystemCommand.format_pathinstead ofexternal_pathSystemCommand.headless_environmentinstead ofheadless_environmentSystemCommand.find_executableinstead of manual executable searchRefactor
GhostscriptWrapperto use:SystemCommand.find_executableinstead offind_in_pathRemove duplicated methods from wrappers:
external_path(was in InkscapeWrapper)headless_environment(was in InkscapeWrapper)find_in_path(was in GhostscriptWrapper)Benefits
Platformfor OS detection,SystemCommandfor command execution