-
Notifications
You must be signed in to change notification settings - Fork 31
Korean CP949 encodings. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @ageldama, sorry for taking so long to get back to you. I rebased your changes to a single commit, then added some very minor refactorisations and indentation tweaks for consistency with the rest of the code. I put that here: https://github.com/luismbo/babel/tree/pr-21. Please let me know if it looks OK to you. |
|
@ageldama meanwhile, I've written a test for the CP949 encoding and it's failing. For example: Here's the complete test: luismbo@82f0bfc Can you have a look? |
|
No problem. :-) thanks! |
|
OK, but it should signal an encoding error rather than a random program error. |
|
No problem @ageldama! Good luck at your new city. |
|
Hello @ageldama. Welcome back. :-) Which test case needs to be reviewed? Travis CI says all tests have passed. Is it some other test that hasn't been committed yet? |
Refactor Korean CP949 Decoder.
(Revised for unmappable chars.)
--- DELETED ---