Skip to content

Conversation

@ageldama
Copy link

@ageldama ageldama commented Oct 4, 2014

--- DELETED ---

@luismbo
Copy link
Member

luismbo commented Nov 23, 2014

Hello @ageldama, sorry for taking so long to get back to you. I rebased your changes to a single commit, then added some very minor refactorisations and indentation tweaks for consistency with the rest of the code. I put that here: https://github.com/luismbo/babel/tree/pr-21. Please let me know if it looks OK to you.

@luismbo
Copy link
Member

luismbo commented Nov 24, 2014

@ageldama meanwhile, I've written a test for the CP949 encoding and it's failing.

For example:

BABEL-TESTS> (octets-to-string (ub8v #xC9 #xA1) :encoding :cp949)

The value NIL is not of type (MOD 1114112).
    [Condition of type TYPE-ERROR]

Here's the complete test: luismbo@82f0bfc

Can you have a look?

@luismbo
Copy link
Member

luismbo commented Nov 25, 2014

No problem. :-) thanks!

@luismbo
Copy link
Member

luismbo commented Nov 29, 2014

OK, but it should signal an encoding error rather than a random program error.

@luismbo
Copy link
Member

luismbo commented Nov 30, 2014

No problem @ageldama! Good luck at your new city.

@luismbo
Copy link
Member

luismbo commented Aug 31, 2016

Hello @ageldama. Welcome back. :-) Which test case needs to be reviewed? Travis CI says all tests have passed. Is it some other test that hasn't been committed yet?

@ageldama ageldama changed the title Korean CP949 and JOHAB encodings. Korean CP949 encodings. Sep 1, 2016
@ageldama ageldama closed this Dec 2, 2020
@ageldama ageldama deleted the kor-cp949 branch December 2, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants