Set values from config where they are used#270
Open
bellisk wants to merge 2 commits intockan:masterfrom
Open
Conversation
Setting all these values from the config at the head of the file does not work when using ckanext-envvars (no matter in which order the plugins are specified in the config). Instead, set them in code before they are used.
Collaborator
|
This would mean unnecessarily loading from config again with every single job. Could it instead be loaded once, but later than module load? Eg by one of the plugin hooks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting all these values from the config at the head of the file does not work when using ckanext-envvars (no matter in which order the plugins are specified in the config). Instead, set them in code before they are used.
Fixes #271