Open
Conversation
davidread
suggested changes
Aug 17, 2020
davidread
left a comment
davidread
left a comment
There was a problem hiding this comment.
Great to see this contribution! Just a question about the test parameter.
Merged
|
First, thanks for the PR and the review. Anything needed except a rebase of the branch with HEAD? |
Collaborator
|
This looks good to me, but @OriHoch can you resolve the merge conflict? |
Collaborator
|
@ThrawnCA are you able to cherry pick his work and make it function. (the file that they wanted to put under test and see the result on load) |
ThrawnCA
referenced
this pull request
in qld-gov-au/ckanext-xloader
Oct 16, 2024
duttonw
pushed a commit
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, unicode characters in headers are encoded to ascii using unidecode library.
This PR adds a config option (
ckanext.xloader.unicode_headers) which allows to keep unicode charactes in the column namesIncludes new tests for this functionality + verified no regressions in existing tests