fix(codex): honor CLI yolo/model and stabilize approval request ids#3
Open
cjb0001 wants to merge 1 commit intofix/codex-resume-passthroughfrom
Open
fix(codex): honor CLI yolo/model and stabilize approval request ids#3cjb0001 wants to merge 1 commit intofix/codex-resume-passthroughfrom
cjb0001 wants to merge 1 commit intofix/codex-resume-passthroughfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Codex permission/model override handling to prevent iOS approval loops in sessions launched with explicit CLI modes (notably
--permission-mode yolo/safe-yolo).Problem
Mobile metadata updates could overwrite CLI-intended mode/model defaults during message handling, causing repeated approvals and unstable permission behavior.
Changes
permission-modeandmodelas authoritative defaults.Files changed
packages/happy-cli/src/codex/messageOverrides.tspackages/happy-cli/src/codex/codexMcpClient.tspackages/happy-cli/src/codex/runCodex.tspackages/happy-cli/src/index.tspackages/happy-cli/src/codex/__tests__/messageOverrides.test.tspackages/happy-cli/src/codex/__tests__/codexMcpClient.test.tsNotes
This PR is stacked on top of
fix/codex-resume-passthroughto keep review diff focused.