prevent memory leak from uncleaned futures - #402
Open
bbortt wants to merge 1 commit into
Open
Conversation
…failure Timed-out and failed requests left `CompletableFuture`, `HttpMessage`, and `LinkedBlockingQueue$Node` instances permanently in `ScenarioEndpoint`'s internal collections, causing unbounded heap growth. - Add `ScenarioEndpoint.cancel()` to remove a future from all internal collections (`orderedFutures`, `pendingFutures`, `channel`, `activeFutures`) - Call `cancel()` in `SimulatorEndpointAdapter` on `TimeoutException`, `InterruptedException`, `ExecutionException`, and synchronous `run()` failure - Fix `fail()` to clean up activeFutures after `receive()` was already called, closing the "received-then-failed" leak path
Collaborator
Author
|
unrelated to #392. if possible:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timed-out and failed requests left
CompletableFuture,HttpMessage,and
LinkedBlockingQueue$Nodeinstances permanently inScenarioEndpoint's internal collections, causing unbounded heap growth.ScenarioEndpoint.cancel()to remove a future from all internal collections (orderedFutures,pendingFutures,channel,activeFutures)cancel()inSimulatorEndpointAdapteronTimeoutException,InterruptedException,ExecutionException, and synchronousrun()failurefail()to clean up activeFutures afterreceive()was already called, closing the "received-then-failed" leak path