feat: check overflow #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a suggestion for how to handle operations that would overflow u64. If an overflow occurs, algorithms will returns an error.
To avoid having a lot of
.checked_add(value).ok_or_else(||SelectionError::AbnormalHighValure)?repeated over the code, which can be a bit hard to read, a simple function sum reside in src/utils.rsAnother way would be to check at select_coin if the values given in inputs and options are abnormal. But then the overflows would still occur if the different algorithms are used directly.