Skip to content

Conversation

@0xEgao
Copy link
Collaborator

@0xEgao 0xEgao commented Dec 28, 2025

fixes #671

@0xEgao 0xEgao force-pushed the v1-test branch 3 times, most recently from 0391cd1 to 63eb2c3 Compare December 28, 2025 14:22
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (776b75d) to head (71ffc49).
⚠️ Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   68.87%   78.22%   +9.35%     
==========================================
  Files          35       49      +14     
  Lines        4932    15125   +10193     
==========================================
+ Hits         3397    11832    +8435     
- Misses       1535     3293    +1758     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojoX911
Copy link

@0xEgao, similar to the taproot swaps, we should name the V1 swaps with taker-abort and maker-abort names. I don't know why I named it this way. But the current names are very confusing. Can be changed in this PR itself.

@0xEgao
Copy link
Collaborator Author

0xEgao commented Dec 30, 2025

Have made the suggested changes i.e. -:
1-) Ensure makers don't get forced shutdown before recovering their swapcoins (if any present).
2-) Changed the test names as suggested.
3-) added contract balance logging, as well improved comments about balances check wherever possible.

@mojoX911 mojoX911 self-requested a review December 30, 2025 10:54
@0xEgao 0xEgao force-pushed the v1-test branch 7 times, most recently from ec607c0 to 19d1ab5 Compare December 30, 2025 17:21
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@mojoX911 mojoX911 merged commit 627bfaf into citadel-tech:master Jan 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V1 Integration Tests Fail Sporadically Due to Shared Balance Verification and Assertion's Overload

3 participants