-
Notifications
You must be signed in to change notification settings - Fork 96
test: added few taproot integration test case #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 68.87% 77.76% +8.88%
==========================================
Files 35 49 +14
Lines 4932 15126 +10194
==========================================
+ Hits 3397 11762 +8365
- Misses 1535 3364 +1829 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5bac6d5 to
14a4c84
Compare
mojoX911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Ack. Just one major comment for all the test cases.
Instead of asserting for a range (< or >) can we assert for exact values? For all swaps that failed, succeeded, or recovered, the difference between balances should always be a fixed constant number. So we can assert for that number directly, and also mention in a comment why this difference in balance is occurring.
Currently, we are not able to see how much exactly the takers and makers are losing in each scenario.
Done |
|
Have used |
|
@0xEgao I think we should also assert for banning behaviors in the taproot tests, just as we do it for V1 tests also. info!("🚫 Verifying naughty maker gets banned");
// Maker gets banned for being naughty.
assert_eq!(
format!("127.0.0.1:{naughty}"),
taker.get_bad_makers()[0].address.to_string()
); |
|
Have made the suggested changes i.e. : |
6bf12dd to
087c70b
Compare
|
@stark-3k can you mark the following TODOs in the tests:
We will turn these todos into issues later, after release. For now this is good to go. |
mojoX911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
This PR works on adding the remaining edge cases to test to ensure the Taproot-based Coinswap protocol works effectively and safely under both normal and failure conditions.
Works on issue #658
Already Covered Test Cases
SenderContractfrom TakerSenderContractFromMakerSenderContractFromMakerPrivateKeyHandoverPrivateKeyHandoverAdded in This PR
AckResponseonSwapDetailsPrivateKeyHandoverby TakerAckResponsefrom MakerSenderContractfrom TakerSenderContractFromMaker