Add Kyber #60
Open
Add Kyber #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
reviewed
Nov 28, 2022
crypto.go
Outdated
|
|
||
| type kyber512PrivateKey struct { | ||
| priv *kyber512.PrivateKey | ||
| pub *kyber512.PublicKey |
There was a problem hiding this comment.
No need to store the public key along: kyberx.PrivateKey already contains a kyberx.PublicKey. Use the Public() function.
Collaborator
Author
|
@bwesterb suggested adding Kyber768. This led me to discover CIRCL's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SIKE is now broken, we need a better example PQ integration.