refactor: get agent resources on demand #324
Open
+65
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to timing issues when agents are periodically sending their resources, we need to refactor the way controller handles agent resources. Instead of having a polling mechanism from agents to send their resources using a fixed interval, now controller asks for resources whenever it needs them. For that reason, code was refactored to get agent resources whenever a start or update command is received. We added a mechanism that sends an rpc command to all agents then it will wait for all agents to return their resources before continuing with start or update. Did cleanup on polling code on agent and resources classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to timing issues when agents are periodically sending their resources, we need to refactor the way controller handles agent resources. Instead of having a polling mechanism from agents to send their resources using a fixed interval, now controller asks for resources whenever it needs them. For that reason, code was refactored to get agent resources whenever a start or update command is received. We added a mechanism that sends an rpc command to all agents then it will wait for all agents to return their resources before continuing with start or update. Did cleanup on polling code on agent and resources classes.
Type of Change
Checklist