-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat: Element Call #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: Element Call #2536
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This works (barely). I know another implementation is in the works. But I want to keep recommending Cinny to people and the lack of calling is a deal breaker to many |
| "linkify-react": "4.1.3", | ||
| "linkifyjs": "4.1.3", | ||
| "matrix-js-sdk": "38.2.0", | ||
| "matrix-js-sdk": "34.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended that you seem to be downgrading matrix-js-sdk here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this was just me copy pasting stuff over from element web to get it to work. It can get updated.
The widget box needs a lot of improvement too. It could have a picture in picture and a fullscreen. I think fullscreen is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I would agree. I have also been looking at #2512 (which looked promising) and having not much luck running that one either. :/
I'd like to use cinny but the lack of video calling is a major blocker.
Description
Note: this is very much AI generated and not yet thoroughly tested
This implements the widget API inasmuch to get embedded Element Call to work. I'll probably maintain this as a fork, but I'm submitting a PR in case there's any desire for it
Type of change
Checklist: