Conversation
- Add examples/ci-watcher.sh with full documentation and setup guide - Replace inline CI/CD hook snippet with reference to example script - Remove deprecated CLAUDE_CODE_SSE_PORT from configuration docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0700cad4a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RUNS_JSON=$(gh run list --repo "$REPO" --commit "$SHA" --created ">=$START_TIME" \ | ||
| --json databaseId,name,status,conclusion --limit 50 2>/dev/null || echo "[]") |
There was a problem hiding this comment.
Stop filtering out pre-existing runs for the same commit
The polling query uses gh run list --commit "$SHA" --created ">=$START_TIME", where START_TIME is captured only when this hook starts. Since gh run list --created filters by run creation time, any workflow run that was created during/just before git push completion is excluded even though it belongs to the pushed commit. In that scenario the watcher can miss all relevant runs and eventually time out without sending pass/fail notifications.
Useful? React with 👍 / 👎.
| # Only trigger on gh pr create or git push (not --delete) | ||
| if echo "$CMD" | grep -qE "gh pr create"; then | ||
| : | ||
| elif echo "$CMD" | grep -qE "git push" && ! echo "$CMD" | grep -qE "--delete|-d"; then |
There was a problem hiding this comment.
Treat
--delete as a grep pattern, not an option
The delete-push guard calls grep -qE "--delete|-d", but because the pattern starts with -, grep parses it as an option, errors, and returns non-zero. With the surrounding ! ..., that failure becomes truthy, so git push --delete is incorrectly treated as a normal push and starts CI watching. Add an option terminator (for example grep -qE -- "--delete|-d") so delete pushes are actually excluded.
Useful? React with 👍 / 👎.
Summary
examples/ci-watcher.sh추가 — GitHub Actions CI 결과를 Pulse로 알려주는 hook 스크립트CLAUDE_CODE_SSE_PORT환경변수 항목 제거Test plan
🤖 Generated with Claude Code