Update Get Vulnerability Details action to use the latest api version#585
Update Get Vulnerability Details action to use the latest api version#585viktor-orca wants to merge 20 commits intochronicle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @viktor-orca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the integration with the Orca Security API for retrieving vulnerability details. By adopting a new query builder and an updated pagination strategy, the system can now fetch vulnerability data more effectively and with greater control. The changes also enhance the parsing of vulnerability information into structured objects and expand the handling of various severity levels, leading to more robust and accurate security insights. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Orca Security integration to use a newer API version for fetching vulnerability details. The changes introduce a new VulnerabilityQueryBuilder, a new pagination logic, and update the parser for the new response format. While the changes are generally in the right direction, I've found a critical bug in the new pagination logic that will cause it to terminate prematurely. I've also identified a potential issue with a payload key in the new query builder that may not be correct for a JSON API. Additionally, there are a few areas for improvement regarding code simplification and adherence to the repository's style guide, particularly concerning docstrings.
content/response_integrations/third_party/partner/orca_security/core/OrcaSecurityManager.py
Outdated
Show resolved
Hide resolved
content/response_integrations/third_party/partner/orca_security/core/query_builder.py
Show resolved
Hide resolved
content/response_integrations/third_party/partner/orca_security/core/OrcaSecurityManager.py
Outdated
Show resolved
Hide resolved
content/response_integrations/third_party/partner/orca_security/core/OrcaSecurityParser.py
Outdated
Show resolved
Hide resolved
content/response_integrations/third_party/partner/orca_security/core/OrcaSecurityParser.py
Outdated
Show resolved
Hide resolved
content/response_integrations/third_party/partner/orca_security/core/query_builder.py
Show resolved
Hide resolved
Fix for Get Asset details
Fix for Get Asset details
|
Hello @viktor-orca are you part of the orca team? |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageorca_security
|
Hi @AmitJ98 , yes i am. |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stageorca_security
|
ok, so first of all you need to sign the google cla. |
Get Vulnerability Details, Get Compliance Info, Get Asset Details Updated the integration to support latest API version
Description
📋 Files Modified
🔄 Major Changes Summary
API Migration & Query Building
get_frameworks()
API Endpoints Updated
Severity System Overhaul
POSSIBLE_SEVERITIES = [
"critical",
"high",
"medium",
"low",
"unknown",
]
SEVERITY_MAPPING = {
"critical": 100,
"high": 80,
"medium": 60,
"low": -1,
"unknown": -1,
}
Completely New VulnerabilityQueryBuilder Class
Breaking Changes:⚠️
Improvements: ✅
Compatibility: 🔄
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback.