Skip to content

Fix jest config / fix card test#26

Open
Sabrinovsky wants to merge 5 commits intochristopher-caldwell:masterfrom
Sabrinovsky:fix/tests
Open

Fix jest config / fix card test#26
Sabrinovsky wants to merge 5 commits intochristopher-caldwell:masterfrom
Sabrinovsky:fix/tests

Conversation

@Sabrinovsky
Copy link
Copy Markdown
Collaborator

@Sabrinovsky Sabrinovsky commented Jul 4, 2024

Fix jest setup for typecript.
Fix card test, now we can start to fix other tests.

Related Issue

solves #27
solves #28
solves #35

@Sabrinovsky Sabrinovsky marked this pull request as draft July 4, 2024 22:45
@Sabrinovsky Sabrinovsky marked this pull request as ready for review July 5, 2024 19:58
@Sabrinovsky Sabrinovsky changed the title Fix/tests Fix jest config / fix card test Jul 6, 2024
@christopher-caldwell
Copy link
Copy Markdown
Owner

I cloned this and ran yarn test:watch and got a missing dependency error.
Screen Shot 2024-09-18 at 7 23 47 PM

Do we need to add this a dev dep of the project?

@christopher-caldwell
Copy link
Copy Markdown
Owner

Sorry for the delay!

@Sabrinovsky
Copy link
Copy Markdown
Collaborator Author

I cloned this and ran yarn test:watch and got a missing dependency error. Screen Shot 2024-09-18 at 7 23 47 PM

Do we need to add this a dev dep of the project?

i have removed this dependency. Note that this branch is on my fork of this repo, maybe you dont have the branch updated.

@Sabrinovsky
Copy link
Copy Markdown
Collaborator Author

I just updated the CI to run the tests. You can see that it is running without the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants