Fix broken horizon-terminal-* slugs #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base16-horizon-terminal-dark theme previously referred to base16-horizon-dark instead, and similarly for -light. This is definitely incorrect for the `g:colors_name` variable, as that should match the name of the colorscheme. I'm not sure whether this was intentional for base16-shell purposes as I don't use that software so haven't tested it, but if not then probably the root cause is an error in whatever .yaml was fed to the template to generate these files (I looked briefly and couldn't find the source of those).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base16-horizon-terminal-dark theme previously referred to base16-horizon-dark instead, and similarly for -light. This is definitely incorrect for the
g:colors_namevariable, as that should match the name of the colorscheme. I'm not sure whether this was intentional for base16-shell purposes as I don't use that software so haven't tested it, but if not then probably the root cause is an error in whatever .yaml was fed to the template to generate these files (I looked briefly and couldn't find the source of those).