Improve debug logging for mesh packets#99
Closed
mullerch wants to merge 1 commit intochirpstack:masterfrom
Closed
Conversation
Signed-off-by: Christian Müller <christian.muller@wifx.net>
Contributor
|
I've fixed an issue with the test and merged this. Thanks @mullerch 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, LoRa proprietary packets are all considered as ChirpStack mesh packets, leading to several types of error and warnings on parsing.
The nominal use of the Gateway Mesh should not report any errors/warnings for some other packets being ignored. It should only report errors that affect the software functionality as errors. In the same way, packet signed with another mesh network MIC should not log warnings, as ignoring those packets is the expected behavior.
In this PR, those errors and warning have some details added to better understand why the packets are ignored and are logged in the debug level. If the use case is debugging the mesh network, the debug level should be enabled.