Remove deprecated GenericArray usage#100
Merged
brocaar merged 1 commit intochirpstack:masterfrom Jan 28, 2026
Merged
Conversation
Signed-off-by: Christian Müller <christian.muller@wifx.net>
Contributor
|
Thanks @mullerch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the AES-128 encryption code to simplify usage of the
aescrate and improve code clarity. The main changes remove unnecessary dependencies onGenericArray, update cipher initialization to use the more idiomaticnew_from_slicemethod, and make minor improvements to buffer handling.AES-128 cipher usage improvements:
GenericArraywith direct use ofAes128::new_from_slicefor cipher initialization insrc/aes128.rsandsrc/packets.rs, making the code more concise and idiomatic.Block::fromandBlock::from_mut_sliceas appropriate, further simplifying the code and improving readability.Code clarity and correctness:
Vec<u8>to[u8; 16]arrays and replacedclone_from_slicewithcopy_from_slicefor better type safety and clarity insrc/packets.rs.<Cmac<Aes128> as Mac>::new_from_slice.