Fixed conflict with KDE's elisa#158
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Debian packaging script to prefix package names with lisa-. However, the current implementation only declares Conflicts and Replaces for the elisa service. The reviewer correctly pointed out that all renamed services (elisa, elisheba, and isabel) will encounter file conflicts during upgrades, and suggested unconditionally declaring these fields for all services to ensure a smooth upgrade path.
| if [ "$service" = "elisa" ]; then | ||
| cat >> "$package_root/DEBIAN/control" <<EOF | ||
| Conflicts: elisa | ||
| Replaces: elisa | ||
| EOF | ||
| fi |
There was a problem hiding this comment.
Since all services (elisa, elisheba, and isabel) are being renamed to have the lisa- prefix (e.g., lisa-elisheba, lisa-isabel), they will all encounter file conflicts during upgrades if the old packages are already installed (since they install files to the same paths like /usr/bin/$service).
To ensure a smooth upgrade path and prevent dpkg file conflict errors for all services, we should unconditionally declare Conflicts and Replaces against the old $service name, rather than limiting this only to elisa.
| if [ "$service" = "elisa" ]; then | |
| cat >> "$package_root/DEBIAN/control" <<EOF | |
| Conflicts: elisa | |
| Replaces: elisa | |
| EOF | |
| fi | |
| cat >> "$package_root/DEBIAN/control" <<EOF | |
| Conflicts: $service | |
| Replaces: $service | |
| EOF |
1 participant
No description provided.